Allow reordering of array literal expressions #1323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackofdiamond5
added
angular-modules
❌ status: awaiting-test
core
…o override arr initializer
jackofdiamond5
force-pushed
the
bpenkov/reordering-array-literals
branch
from
0bac5a5 to
c04e5c3
Compare
jackofdiamond5
force-pushed
the
bpenkov/reordering-array-literals
branch
from
c04e5c3 to
8828462
Compare
wnvko
previously approved these changes
Oct 31, 2024
Contributor
wnvko
left a comment
wnvko
left a comment
There was a problem hiding this comment.
In the end we will sort all the IGX things after everything else. Hope this will not break anything.
valadzhov
added
💥 status: in-test
✅ status: verified
and removed
❌ status: awaiting-test
💥 status: in-test
✅ status: verified
labels
Contributor
|
The issue is not reproducible with this ordering but it is not the desired one where the Igx items are last. |
valadzhov
added
🛠️ status: in-development
status: completed
and removed
💥 status: in-test
🛠️ status: in-development
labels
Contributor
|
This logic does not sort the imports of projects created with the CLI, it is related to the sorting of imports of projects created with the CodeGen and since this was tested yesterday I changed the status of the task to "Completed". |
…rdering-array-literals
Lipata
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes AzureDevOps#34206
This PR adds the ability to sort array literal expressions in the
TypeScriptAstTransformerand then uses that to allow ordering of property assignments inAngulardecorators. The targeted property assignment must be an array literal expression.Additionally, some minor enhancements have been introduced like the
overrideoption when adding new members to object literals - if the initializer of the new member exists and is an array literal, by default, the transformer will append all new values to the currently existing array literal, removing any duplicates. With theoverrideoption set, the transformer will replace the entire initializer with the new values.Also, some new types have been added to reduce the parameter lists for some methods and new enumerations to better indicate
Angularspecific keywords related to decorators.The PR also bumps
TypeScriptto5.5.4to match the version of the rest of the sub-projects as a mismatch between the versions caused a build error.